• nnrx@lemmy.world
    link
    fedilink
    English
    arrow-up
    2
    ·
    edit-2
    6 months ago

    no lemmy community for mlmym yet, that’s good idea.

    do you have an example of that thumbnail issue?

    • e0qdk@reddthat.com
      link
      fedilink
      English
      arrow-up
      1
      ·
      edit-2
      6 months ago

      I’m having trouble finding an example of the thumbnail issue again right now but I was seeing the pictrs conversion parameters passed to URLs from catbox.moe, i.postimg.cc, and other sources in the CSS for the thumbnail when I reported the issue to Tiff ~3 weeks ago. It’s possible that it got fixed/suppressed by another change since then though. (0.0.44 was deployed a few hours ago and I think there may have also been a beta patch bump for the lemmy backend at some point since I reported the issue originally in our local support community.)

      I’ll let you know if I see it pop up again.

      For the text handling issue, I was seeing text like “<thread title> by <username> in <community>” (i.e. "<thread title> by <username> in <community>" if it still happens) getting misinterpreted as raw HTML instead of being escaped. (i.e. <!-- raw HTML omitted --> was showing up in the HTML output for the page.)

      You may recognize that text as the pattern for a recently fixed bug in the user profiles; I found the text handling issue while trying to explain the other issue to Tiff a few weeks ago.

      Will edit this comment immediately after posting to let you know if I still see the text issue.

      EDIT: I still see the text issue show up in this comment. https://old.reddthat.com/comment/10370610

    • e0qdk@reddthat.com
      link
      fedilink
      English
      arrow-up
      1
      ·
      edit-2
      6 months ago

      I ran into an example of the thumbnail issue again today – this time on a post from kbin: https://old.reddthat.com/post/19193476

      The thumbnail looks like this in the HTML:

      <div class="thumb">
        <a class="url"
           href="https://media.kbin.social/media/60/a4/60a45b8ff88b1b2e3a0f77b701feb323c5bbfb7ceeb75154ea7df5d6eea15ef8.jpg"
           >
          <div  style="background-image: url(https://media.kbin.social/media/60/a4/60a45b8ff88b1b2e3a0f77b701feb323c5bbfb7ceeb75154ea7df5d6eea15ef8.jpg?format=jpg&amp;thumbnail=96)"></div>
        </a>
      </div>
      

      Note that it’s making a request to kbin.social with ?format=jpg&thumbnail=96 parameters in the CSS – which results in the full image being loaded since kbin doesn’t run pictrs.

      The versions in use on reddthat (according to the settings page) are:

      lemmy: 0.19.4-beta.7

      mlmym: 0.0.44